search

Tracktion / tracktion_engine

Tracktion Engine module
Other
1.2k stars 152 forks source link

[Bug]: Failed to clone 'modules/juce' #225

Closed JelleBakker closed 2 months ago

JelleBakker commented 2 months ago

Detailed steps on how to reproduce the bug

Run git clone --recurse-submodules https://github.com/Tracktion/tracktion_engine.git

What is the expected behaviour?

It clones the repo

Unit test to reproduce the error?

Not relevant

Operating systems

macOS

What versions of the operating systems?

macOS Sonoma 14.5

Architectures

ARM

Stacktrace

Cloning into 'tracktion_engine'...
remote: Enumerating objects: 1075880, done.
remote: Counting objects: 100% (67836/67836), done.
remote: Compressing objects: 100% (1321/1321), done.
remote: Total 1075880 (delta 66686), reused 67591 (delta 66467), pack-reused 1008044
Receiving objects: 100% (1075880/1075880), 1.18 GiB | 15.16 MiB/s, done.
Resolving deltas: 100% (1061219/1061219), done.
Submodule 'modules/juce' (git@github.com:juce-framework/JUCE.git) registered for path 'modules/juce'
Cloning into '/Users/jelle/Documents/Developer/tracktion_engine/modules/juce'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:juce-framework/JUCE.git' into submodule path '/Users/jelle/Documents/Developer/tracktion_engine/modules/juce' failed
Failed to clone 'modules/juce'. Retry scheduled
Cloning into '/Users/jelle/Documents/Developer/tracktion_engine/modules/juce'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:juce-framework/JUCE.git' into submodule path '/Users/jelle/Documents/Developer/tracktion_engine/modules/juce' failed
Failed to clone 'modules/juce' a second time, aborting

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

No response

Testing on the develop branch

The bug is present on the develop branch

Code of Conduct

drowaudio commented 2 months ago

This looks like you don't have an SSH key setup for GitHub?

JelleBakker commented 2 months ago

Possibly, but I've not had this issue with Tracktion Engine (or other repo's) before.

What's the reason the submodules URL in .gitmodules file has changed from https://github.com/WeAreROLI/JUCE.git to git@github.com:juce-framework/JUCE.git in this commit?

drowaudio commented 2 months ago

It was because we have a new Action that pulls the latest juce tip and tries to build against it to check upstream compatibility. You can't do that with https submodules easily.