codecov[bot]
commented
3 years ago Codecov Report
Merging #69 (45e1988) into master (6659045) will increase coverage by
2.02%. The diff coverage is97.05%.
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 82.04% 84.06% +2.02%
==========================================
Files 29 29
Lines 2389 2454 +65
==========================================
+ Hits 1960 2063 +103
+ Misses 429 391 -38 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/LogicCircuits.jl | 100.00% <ø> (ø) |
|
| src/queries.jl | 97.60% <75.00%> (-0.78%) |
:arrow_down: |
| src/transformations.jl | 95.54% <98.27%> (+0.20%) |
:arrow_up: |
| src/Utils/data.jl | 65.66% <100.00%> (ø) |
|
| src/Utils/trees.jl | 98.38% <100.00%> (+0.02%) |
:arrow_up: |
| src/satisfies_flow.jl | 47.45% <100.00%> (+14.93%) |
:arrow_up: |
| src/abstract_logic_nodes.jl | 91.76% <0.00%> (+1.17%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6659045...7c9058f. Read the comment docs.
This adds smoothing for structured logic circuits, respecting the current vtree. Appears to be working - looking for more example tests that don't have dependencies in Probabilistic circuits. I couldn't find a way around doing work at both AND and OR nodes, it's possible there is some unnecessary work going on. As of right now this will only work on logic circuits due to typing issues. A future pr should add a "structured decomposable" trait which would allow this to work with structured prob nodes as well.