Tractables / LogicCircuits.jl

Logic Circuits from the Juice library
https://tractables.github.io/LogicCircuits.jl/dev/
Apache License 2.0
48 stars 4 forks source link

Infer vtree #85

Closed talf301 closed 3 years ago

talf301 commented 3 years ago

Correct code for inferring a vtree and testing structured decomposability. Requires the circuit to be smooth. The code doesn't care about what order the and nodes are in - that is, there's no distinction between left and right. The returned vtree's left and right orientations will just be based on whatever the orientation was the first time it hit that node in the vtree when recursing down.

This closes #82.

codecov[bot] commented 3 years ago

Codecov Report

Merging #85 (9c27fa3) into master (c101701) will increase coverage by 0.05%. The diff coverage is 100.00%.

:exclamation: Current head 9c27fa3 differs from pull request most recent head 389a8ab. Consider uploading reports for the commit 389a8ab to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   86.89%   86.94%   +0.05%     
==========================================
  Files          30       30              
  Lines        2586     2589       +3     
==========================================
+ Hits         2247     2251       +4     
+ Misses        339      338       -1     
Impacted Files Coverage Δ
src/Utils/data.jl 81.76% <100.00%> (+0.10%) :arrow_up:
src/queries/queries.jl 95.45% <100.00%> (+0.67%) :arrow_up:
src/sdd/sdd_functions.jl 99.09% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c101701...389a8ab. Read the comment docs.

khosravipasha commented 3 years ago

nice :D you can ignore the "Slow Tests", failing for other reasons.