Tractables / LogicCircuits.jl

Logic Circuits from the Juice library
https://tractables.github.io/LogicCircuits.jl/dev/
Apache License 2.0
48 stars 4 forks source link

CompatHelper: bump compat for "DataFrames" to "1.1" #87

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the DataFrames package from 0.21, 0.22 to 0.21, 0.22, 1.1.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 3 years ago

Codecov Report

Merging #87 (61cd0e5) into master (36d8fe5) will decrease coverage by 1.39%. The diff coverage is n/a.

:exclamation: Current head 61cd0e5 differs from pull request most recent head 4258850. Consider uploading reports for the commit 4258850 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   88.33%   86.94%   -1.40%     
==========================================
  Files          30       30              
  Lines        2590     2589       -1     
==========================================
- Hits         2288     2251      -37     
- Misses        302      338      +36     
Impacted Files Coverage Δ
src/queries/satisfies.jl 62.24% <ø> (-14.29%) :arrow_down:
src/transformations.jl 95.81% <ø> (-0.33%) :arrow_down:
src/Utils/cubitvector.jl 33.33% <0.00%> (-16.67%) :arrow_down:
src/queries/satisfies_flow.jl 47.18% <0.00%> (-4.77%) :arrow_down:
src/Utils/data.jl 81.76% <0.00%> (-3.32%) :arrow_down:
src/bit_circuit.jl 81.30% <0.00%> (-1.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36d8fe5...4258850. Read the comment docs.

khosravipasha commented 3 years ago

Fails for the following case, need to double check why that is happening.

circuit(false, true, true) # sun is false, rain is true, rainbow is true

Stacktrace: [1] error(::String) at ./error.jl:33 [2] execute_block(::Module, ::String) at /home/runner/.julia/packages/Literate/kB2Gm/src/Literate.jl:720 [3] execute_markdown!(::Base.GenericIOBuffer{Array{UInt8,1}}, ::Module, ::String, ::String) at /home/runner/.julia/packages/Literate/kB2Gm/src/Literate.jl:479 [4] markdown(::String, ::String; config::Dict{Any,Any}, kwargs::Base.Iterators.Pairs{Symbol,Any,NTuple{4,Symbol},NamedTuple{(:documenter, :credit, :execute, :preprocess),Tuple{Bool,Bool,Bool,Base.var"#62#63"{typeof(hide_plots),typeof(replace_includes)}}}}) at /home/runner/.julia/packages/Literate/kB2Gm/src/Literate.jl:463 [5] top-level scope at /home/runner/work/LogicCircuits.jl/LogicCircuits.jl/docs/make.jl:39 [6] include(::Function, ::Module, ::String) at ./Base.jl:380 [7] include(::Module, ::String) at ./Base.jl:368 [8] exec_options(::Base.JLOptions) at ./client.jl:296 [9] _start() at ./client.jl:506 in expression starting at /home/runner/work/LogicCircuits.jl/LogicCircuits.jl/docs/make.jl:39 Error: Process completed with exit code 1.