search

Tractables / LogicCircuits.jl

Logic Circuits from the Juice library
https://tractables.github.io/LogicCircuits.jl/dev/
Apache License 2.0
48 stars 4 forks source link

Upgrade to dataframes 1.x #94

Closed khosravipasha closed 3 years ago

khosravipasha commented 3 years ago

Biggest changes are:

  1. Cannot do DataFrame(matrix) anymore, and need to either do DataFrame(matrix, :auto) or DataFrame(Tables.table(matrix)).

  2. Cannot use Base.convert for converting DataFrame to matrix, should use Tables.matrix(dataframe) instead.

codecov[bot] commented 3 years ago

Codecov Report

Merging #94 (aa712c5) into master (5c69413) will increase coverage by 0.03%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   88.08%   88.11%   +0.03%     
==========================================
  Files          31       31              
  Lines        3197     3198       +1     
==========================================
+ Hits         2816     2818       +2     
+ Misses        381      380       -1
Impacted Files Coverage Δ
src/queries/satisfies.jl 62.24% <ø> (ø)
src/queries/satisfies_flow.jl 47.18% <0.00%> (ø)
src/LoadSave/data_loaders.jl 50.00% <50.00%> (+2.17%) :arrow_up:
src/Utils/data.jl 81.76% <100.00%> (ø)
src/transformations.jl 96.14% <0.00%> (+0.32%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c69413...aa712c5. Read the comment docs.