search

Tractables / LogicCircuits.jl

Logic Circuits from the Juice library
https://tractables.github.io/LogicCircuits.jl/dev/
Apache License 2.0
48 stars 4 forks source link

Fix BDDs overwriting LoadSave.load_cnf #96

Closed RenatoGeh closed 3 years ago

RenatoGeh commented 3 years ago

Hi,

This patch fixes an issue where LoadSave.load_cnf and LoadSave.load_dnf would be obscured by the BDD code introduced in #90.

Since the code is provisional until we fully integrate BDDs into LogicCircuits, I didn't move the code to LoadSave and instead extended the corresponding functions for BDDs. This will make it easier for late refactoring, since all BDD code will be in one place.

Thanks!

codecov[bot] commented 3 years ago

Codecov Report

Merging #96 (bcaf8fb) into master (bd48e34) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   88.11%   88.08%   -0.04%     
==========================================
  Files          31       31              
  Lines        3198     3198              
==========================================
- Hits         2818     2817       -1     
- Misses        380      381       +1
Impacted Files Coverage Δ
src/bdd/bdds.jl 92.89% <100.00%> (ø)
src/transformations.jl 95.81% <0.00%> (-0.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd48e34...bcaf8fb. Read the comment docs.