Tractables / ProbabilisticCircuits.jl

Probabilistic Circuits from the Juice library
https://tractables.github.io/ProbabilisticCircuits.jl/dev
Apache License 2.0
104 stars 11 forks source link

Em log and data softening #124

Closed MhDang closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 42.05% // Head: 41.86% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (35db307) compared to base (e063c82). Patch coverage: 6.25% of modified lines in pull request are covered.

:exclamation: Current head 35db307 differs from pull request most recent head 0c9fe8a. Consider uploading reports for the commit 0c9fe8a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #124 +/- ## ========================================== - Coverage 42.05% 41.86% -0.20% ========================================== Files 23 23 Lines 1881 1892 +11 ========================================== + Hits 791 792 +1 - Misses 1090 1100 +10 ``` | [Impacted Files](https://codecov.io/gh/Juice-jl/ProbabilisticCircuits.jl/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Juice-jl) | Coverage Δ | | |---|---|---| | [src/parameters/em.jl](https://codecov.io/gh/Juice-jl/ProbabilisticCircuits.jl/pull/124/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Juice-jl#diff-c3JjL3BhcmFtZXRlcnMvZW0uamw=) | `4.06% <0.00%> (-0.13%)` | :arrow_down: | | [src/nodes/indicator\_dist.jl](https://codecov.io/gh/Juice-jl/ProbabilisticCircuits.jl/pull/124/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Juice-jl#diff-c3JjL25vZGVzL2luZGljYXRvcl9kaXN0Lmps) | `66.66% <50.00%> (-2.09%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Juice-jl). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Juice-jl)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

guyvdbroeck commented 2 years ago

what is the meaning of flowflag?

MhDang commented 2 years ago

That part is to compute the lower bound of pruning edges and I forgot to remove it. Will remove and re-commit.