search

Tractables / ProbabilisticCircuits.jl

Probabilistic Circuits from the Juice library
https://tractables.github.io/ProbabilisticCircuits.jl/dev
Apache License 2.0
104 stars 11 forks source link

[API improvement] Remove data from *BitCircuit signiture #32

Closed khosravipasha closed 2 years ago

khosravipasha commented 4 years ago

We give data to BitCircuit but they only use it to count how many num_features there are, don't need the data for that. Might be better to just give the count. Unless I am missing something here.

https://github.com/Juice-jl/LogicCircuits.jl/blob/e42cd0806fafbf4db09138fdceb8b88a991d5c3d/src/bit_circuit.jl#L73-L75

Because of this then all ParamBitCircuit, etc also have to pass in the data.

khosravipasha commented 2 years ago

This is also will be gone in v0.4 so closing.