Save/Load operations not fully supported

khosravipasha commented 4 years ago

Keeping track of what's needed

[x] Cannot save circuit without vtree (workaround: use infer_vtree to do that after fixing its limitation Juice-jl/LogicCircuits.jl#47)
[x] Cannot save circuit that is not struct decomposable, need to choose a format for those cases.
[x] Cannot save CNF/DNFs (can only load them)
[x] Save a Prob/Logistic/Regression circuit without vtree
[ ] ~~Saving/Loading of regression circuits (now mostly support logistic circuits only)~~
[x] Save/Load mixture models, (eg from strudel). See https://github.com/Juice-jl/ProbabilisticCircuits.jl/issues/28 for suggestions.

For the load/save of Strudel (mixtures), one suggestion is that save all related files and metadata in a single Zip file (with appendix .strudel). We need the structure, the vtree, the mixture weights, and paramters. (maybe more). One option is using ZipFile.jl. Also see Juice-jl/LogicCircuits.jl#12

khosravipasha commented 3 years ago

Also related to Juice-jl/LogicCircuits.jl#40

guyvdbroeck commented 3 years ago

The first 3 check boxes above are resolved in https://github.com/Juice-jl/LogicCircuits.jl/pull/99 The remaining ones should be moved to https://github.com/Juice-jl/ProbabilisticCircuits.jl

khosravipasha commented 3 years ago

@guyvdbroeck Last one was saving strudel models whichI think we have now in `ensemble_io.jl"?
so closing this.

Tractables / ProbabilisticCircuits.jl

Save/Load operations not fully supported #86