search

TradeMaster-NTU / TradeMaster

TradeMaster is an open-source platform for quantitative trading empowered by reinforcement learning :fire: :zap: :rainbow:
Apache License 2.0
1.35k stars 273 forks source link

Default branch change #189

Open lakshya-aga opened 11 months ago

lakshya-aga commented 11 months ago

When installing using the instructions for docker for arm, some issues are encountered. I believe its because of the default branch being 1.0.0 in the dockerfile. Thus, one can't run the experiment for checking installation. I changed it to specify the branch to main for myself but I presume others might encounter this issue as well

lakshya-aga commented 11 months ago

Additionally, one should install the essentials i.e. GNU compiler suite as well as some other tools using:

apt-get update &&  apt-get install cmake libopenmpi-dev python3-dev zlib1g-dev libgl1-mesa-glx swig
apt install build-essential
pip install -r requirement/requirements_arm.txt

before they can run the experiment as the container does not have anything installed.

SUSHANTH009 commented 11 months ago

Additionally, one should install the essentials i.e. GNU compiler suite as well as some other tools using:

apt-get update &&  apt-get install cmake libopenmpi-dev python3-dev zlib1g-dev libgl1-mesa-glx swig
apt install build-essential
pip install -r requirement/requirements_arm.txt

before they can run the experiment as the container does not have anything installed.

were you able to install using docker, even I am having problem while installation

lakshya-aga commented 11 months ago

Yes I installed using Docker

Colin123 commented 11 months ago

The docker file doesn't work for me, did you have to make any changes to it?

See my remarks here, I raised a ticket: https://github.com/TradeMaster-NTU/TradeMaster/issues/190

Thanks

lakshya-aga commented 11 months ago

I used the docker file at docker/arm in the main branch not 1.0.0 I can't use the default one since that uses cuda and I'm a mac M1 user. There is an x86 arch dockerfile there also if that's the system you are running

Colin123 commented 11 months ago

Currently I'm using x86 but I just ordered a new ARM Mac which will be delivered in a couple of weeks. Could you perhaps post the working docker file? Would really appreciate it if you could :-) In any case, thanks for the info

Colin123 commented 11 months ago

Oh wait, I think I see what you mean. Just use the main branch and use the above changes. x86 in the main branch looks ok so far much appreciated