Open agnel opened 11 years ago
djmc
commented
11 years ago Also
if the extension is other than .js or .css it won't be loaded or even cached
It looks like this behaviour hasn't changed in your commit. However, would prefer that this functionality be kept, as it is used by us to store our handlebars templates (they're stored in HTML).
djmc
commented
11 years ago Other files types don't get injected, but they'll still get cached and made accessible. Read the README and see the section "Advanced File Loading".
agnel
commented
11 years ago Yeah, it'll be good for storing images!
On Sat, Nov 10, 2012 at 9:49 PM, Daniel McKenzie notifications@github.comwrote:
Other files types don't get injected, but they'll still get cached and made accessible. Read the README and see the section "Advanced File Loading".
— Reply to this email directly or view it on GitHubhttps://github.com/TradeMe/bootup.js/pull/14#issuecomment-10256693.
agnel
commented
11 years ago There is a similar script - basket.jshttp://addyosmani.github.com/basket.js/ - but its limited only to storing javascripts!
On Sat, Nov 10, 2012 at 9:52 PM, agnel waghela agnelwaghela@gmail.comwrote:
Yeah, it'll be good for storing images!
On Sat, Nov 10, 2012 at 9:49 PM, Daniel McKenzie <notifications@github.com
wrote:
Other files types don't get injected, but they'll still get cached and made accessible. Read the README and see the section "Advanced File Loading".
— Reply to this email directly or view it on GitHubhttps://github.com/TradeMe/bootup.js/pull/14#issuecomment-10256693.
djmc
commented
11 years ago CSS injection will be great, I'll just await the newer code to be committed that takes into the above considerations and will take a look at it.
Change of Execute Function
I re-wrote the execute function for the file to inject it according to the extension i.e .js or .css if the extension is other than .js or .css it won't be loaded or even cached!