search

TradeMe / ng-defer-load

MIT License
127 stars 36 forks source link

Performance Improvements - Reuse same IntersectionObserver as suggested in docs #33

Open naveedahmed1 opened 5 years ago

naveedahmed1 commented 5 years ago

Google Developer docs available at https://developers.google.com/web/updates/2016/04/intersectionobserver suggests:

If you need to observe multiple elements, it is both possible and advised to observe multiple elements using the same IntersectionObserver instance by calling observe() multiple times

It seems that this directive creates new IntersectionObserver for each element, so if there are let;s say 20 images we will end up with 20 IntersectionObservers. What if we could re-use the same IntersectionObserver?

mzoellner commented 4 years ago

Hi @naveedahmed1, that's a great suggestion. Would you mind creating a PR for it ?