search

TradeMe / ng-defer-load

MIT License
127 stars 36 forks source link

Feature Request - Release this plugin as ES2015 module #39

Closed naveedahmed1 closed 4 years ago

naveedahmed1 commented 4 years ago

When compiling Angular project with latest version of Angular CLI it throws below warning:

mytest.module.ts depends on @trademe/ng-defer-load. CommonJS or AMD dependencies can cause optimization bailouts.

Google advises against using CommonJS modules because it can impact the tree-shaking of application as explained here https://web.dev/commonjs-larger-bundles/

I would therefore request you to please release this plugin as es2015 module.

Thank you

mzoellner commented 4 years ago

Hi @naveedahmed1 I have created #40 to address this. Will push a new npm version as well.

naveedahmed1 commented 4 years ago

Thank you so much @mzoellner really appreciate :)