search

TradeTrust / ndi-tradex-poc

https://ndi-tradex-poc.netlify.app
1 stars 0 forks source link

oa-verify polyfills #7

Open simboonlong opened 1 year ago

simboonlong commented 1 year ago

oa-verify open-attestation lib seems to be causing integration problems, which can be overcome by reintroducing back some nodejs polyfills. same issue as https://github.com/TradeTrust/document-creator-website/pull/244

superical commented 1 year ago

Ehh.... I just tried importing oa-verify lib recently in react, didn't get any errors and I also didn't add any polyfills. Just curious, what problems would it cause when importing oa-verify lib? Is the problem only specifically with create-react-app?

simboonlong commented 1 year ago

this only happens with CRA v5 onwards, whereby react-scripts had a bump to webpack5, specifically:

No node js builtin shims (breaking as in Webpack 5)

there is an attempted fix as of now. haven looked into it though

superical commented 1 year ago

Ahh I see! Thanks!