search

Tradeshift / elements

Tradeshift Elements - Reusable Tradeshift UI Components as Web Components https://tradeshift.github.io/elements
Other
15 stars 17 forks source link

Put all used strings in `constant` file #50

Closed Kian-Esmaeilpour closed 5 years ago

Kian-Esmaeilpour commented 5 years ago

We should refactor all the strings. Put them to Constant.js

Originally posted by @zdlm in https://github.com/Tradeshift/elements/pull/46/files

Kian-Esmaeilpour commented 5 years ago

Where should we put them? In the owner component or in core? How we should structure them if it's going to be in core?