Tradeshift / tradeshift-ui

Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
https://ui.tradeshift.com
Other
33 stars 44 forks source link

Marking table rows as unselectable does not match documentation #116

Closed jverducci closed 7 years ago

jverducci commented 7 years ago

In the section for marking a table row as unselectable (http://ui.tradeshift.com/#components/table/selecting.html), it shows the following:

table.rows([ {cells: ['A', 'D', 'G']}, {cells: ['B', 'E', 'H'], selectable: false}, {cells: ['C', 'F', 'I']}, ]);

This does not work because in the code, it is actually expecting for the cells:

cells: [ { text: "stuff", value: “stuff" }, ...]

wiredearp commented 7 years ago

Duplicate of https://github.com/Tradeshift/Client-Runtime/issues/592, which is now closed. Issue was resolved by wrapping the code in ts.ui.ready(function() { thecode() }); to allow for initialization.