Tradeshift / tradeshift-ui

Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
https://ui.tradeshift.com
Other
33 stars 44 forks source link

[S3] Wrong Content-Type is used for less files #195

Closed sampi closed 7 years ago

sampi commented 7 years ago

Tradeshift UI version affected

v7.0.0

Expected Behavior

.less files are uploaded using text/less Content-Type.

Actual Behavior

.less files are uploaded using application/octet-stream Content-Type.

Steps to reproduce

> $ wget --server-response --spider https://d5wfroyti11sa.cloudfront.net/prod/client/ts-runtime-7.0.0-rc.2.less                                                                                                                                                                 ⬡ v6.10.0
Spider mode enabled. Check if remote file exists.
--2017-03-14 16:03:22--  https://d5wfroyti11sa.cloudfront.net/prod/client/ts-runtime-7.0.0-rc.2.less
Resolving d5wfroyti11sa.cloudfront.net... 54.192.14.190, 54.192.14.180, 54.192.14.119, ...
Connecting to d5wfroyti11sa.cloudfront.net|54.192.14.190|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Content-Type: application/octet-stream
  Content-Length: 26810
  Connection: keep-alive
  Date: Tue, 14 Mar 2017 14:25:35 GMT
  Last-Modified: Tue, 14 Mar 2017 13:04:39 GMT
  ETag: "ea21a927f0bdffef69eda52b0e1aacb0"
  Cache-Control: max-age=29030400, public
  Content-Encoding: gzip
  Accept-Ranges: bytes
  Server: AmazonS3
  Age: 2268
  X-Cache: Hit from cloudfront
  Via: 1.1 e1199ec506dcf179c3e277ddd6c51498.cloudfront.net (CloudFront)
  X-Amz-Cf-Id: 1kGgcO4RPojhsUxw05gXsaYfVj3V-p0RcFNPVq6nTgz3u4EcZcbhLQ==
Length: 26810 (26K) [application/octet-stream]
Remote file exists.
sampi commented 7 years ago

fixed starting v7.0.0-rc.5