Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

[TS MultiSelect] Does not allow more than one button #218

Open alinaTS opened 7 years ago

alinaTS commented 7 years ago

Tradeshift UI version affected

v7.1.0

Expected Behavior

Select multiple UI component should be able to handle more than one button. For example:

<label>
    <span>Sample list 1</span>
    <select multiple ng-options="value as (value.ID + ' - ' + value.Name) for value in newList.selectedFilterEntries[$index] track by value.ID" ng-model="newListEntry.FiltersTemp[$index]" ng-change="checkMandatoryEntryInfo();"></select>
    <button>Button 1</button>
    <button>Button 2</button>
</label>

Actual Behavior

Only the first button is displayed, the second is ignored.

Screenshots (optional)

screen shot 2017-03-30 at 12 56 08 pm

sampi commented 7 years ago

How did you imagine the functionality with the buttons? If there's 1 button then submit the form, if there are 2 then select all/select none and then submit right away or do we want the user to click on the X or the grey cover to apply the selection?

alinaTS commented 7 years ago

@sampi That should be for UX team to decide, I would select all/none entries using the second/third button, then confirm the action with the submit form button, or cancel with X.