search

Tradeshift / tradeshift-ui

Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
https://ui.tradeshift.com
Other
33 stars 44 forks source link

The tabs in the Collaboration Panel [in PAY] do not work with long names #22

Closed hassanbugti closed 7 years ago

hassanbugti commented 8 years ago

Tested in Chrome https://slo.eu-west-1.test.ts.sv/#/apps/Tradeshift.TaskList/ Testing: https://tradeshift.atlassian.net/browse/COL-250

See the flow here in the video (as well as the problem): https://drive.google.com/a/tradeshift.com/file/d/0B_kC0e4k5EdTbkg1X2xicXBGdmM/view

wiredearp commented 8 years ago

I'm guessing that a shorter label on the tab can fix some of the weird symptoms we see here, so we should probably assign a max-width to the tabs (but only when the TabBar itself is short, as in the Aside).

hassanbugti commented 8 years ago

image

THis is what it looks like with a short name - just fyi

hassanbugti commented 7 years ago

image

Looks a lot better now @taospace to see the improvement and sign off on it.