search

Tradeshift / tradeshift-ui

Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
https://ui.tradeshift.com
Other
33 stars 44 forks source link

[Panels] refactor to reuse the PanelsPlugin #223

Closed wiredearp closed 6 years ago

wiredearp commented 7 years ago

@sampi and @zdlm

Just a reminder to clean up on some infrastructure: We now support panels-that-automatically-generate-and-coordinate-tabs in:

... and we will probably also support soon in some kind of TabBox component that might also replace second level tabs (popularly referred to as "cards" although this term should be reserved for something else entirely). To avoid further copy-pasting of the business logic involved, there's now a PanelsPlugin in the Modal branch and this should at some point be finalized (to support panels added and removed) and then used in all these instances whenever possible.

wiredearp commented 6 years ago

This is now refactored in such a way that the PanelsPlugin can be deprecated because there's only one spirit, the PanelsSpirit that uses it. Will close the issue.