search

Tradeshift / tradeshift-ui

Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
https://ui.tradeshift.com
Other
33 stars 44 forks source link

ts.ui.Note with button is too big #237

Closed Leonid-Yeromin closed 7 years ago

Leonid-Yeromin commented 7 years ago

Bug report

Tradeshift UI version affected

v7.1.0

screen shot 2017-04-25 at 14 54 59

Expected Behavior

Actual Behavior

Steps to reproduce

Screenshots (optional)

wiredearp commented 7 years ago

I think I made a drive by fix for this over on my branch, whatever I was working on before I went on vacation, I guess it was the jmo/modal branch.

sampi commented 7 years ago

@wiredearp There's no more jmo/modal branch, can you push it somewhere? Otherwise I can do the fix, it's a simple cut & paste in the .tsml of the Note.

wiredearp commented 7 years ago

Well. It was merged to master, then. It also appears fixed over on http://ui.tradeshift.com/#components/notes/.

sampi commented 7 years ago

I just realized my mistake, I'll start the release process of 7.2.0 to fix the issue.