Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

Table component stops working at around 60.000 entries #330

Closed upphiminn closed 7 years ago

upphiminn commented 7 years ago

Table component does not render when entry number exceeded the max call stack size for the browser. Tested it on chrome 59, seems to stop at around 60.000 for my table.


Bug report

Table component does not render when entry number exceeded the max call stack size for the browser. Tested it on chrome 59, seems to stop at around 60.000 for my table.

Tradeshift UI version affected

v8.1.6

Expected Behavior

Render the table

Actual Behavior

Does not render

Steps to reproduce

Create table with 65000 entries for example

Screenshots (optional)

screen shot 2017-07-28 at 11 45 18


Feature request

Use the enhancement label

Description of feature

Example use cases and/or Prototype links

Designs and/or Prototype screenshots

wiredearp commented 7 years ago

This appears to be an exact duplicate of https://github.com/Tradeshift/tradeshift-ui/issues/326, although that other team managed to squeeze in about 200.000 rows before the callstack was exceeded.

:confused: I am (again) not sure that the Table should be expected to handle this many rows on the client side, since it will at some point make searching and sorting extremely slow (and slower in IE and even slower on a mobile phone). That is why the Table can also be configured to run in a "serverside" mode where the pages are rendered one at a time and the Pager is configured manually. I suggest that @upphiminn resort to this option, since we would in any case not have time to optimize the Table in the foreseeable future even if we should decide that this is the best option.