Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

[Forms] Label not colored with red if input contains errors #370

Open n-srg opened 7 years ago

n-srg commented 7 years ago

TSUI v 9.1.1

In case input field contains error: it should render label with red color

Expected Behavior

image

Actual Behavior

image

Steps to reproduce

Go to http://ui.tradeshift.com/#components/forms/example.html And take a look on example related to handling errors

wiredearp commented 7 years ago

@bomouridsen Shouldn't perhaps the blue focus outline also be red until the field is marked as valid?

jerf commented 6 years ago

@wiredearp yes I think it's best that the outline is red in the error state. I need to review the design files that Bo made to answer whether the label should be red as well - I'm not sure that will be necessary when the outline is red.

jerf commented 6 years ago

Yes, outline in red but label stays the same in an error state.

sampi commented 6 years ago

This is how it currently looks in v10 on the docs site:

unfocused

screen shot 2018-02-06 at 16 57 43

focused

screen shot 2018-02-06 at 16 57 53