search

Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

Shaky ESCAPE from Aside #468

Closed wiredearp closed 6 years ago

wiredearp commented 6 years ago

Bug report

Tradeshift UI version affected

v9.3.11

Expected Behavior

The Aside should close on ESCAPE

Actual Behavior

It sometimes does, but at other times it needs multiple ESCAPE before it closes; and on OS X it appears to not work at all or what ❓

Steps to reproduce

Open the Aside. Press ESCAPE. Behold the bug.

DocGroth commented 6 years ago

Fixed with https://github.com/Tradeshift/tradeshift-ui/pull/514