search

Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

Pagination is not displayed correctly on mobile #501

Closed MirelaPaun closed 6 years ago

MirelaPaun commented 6 years ago

Bug report

Pagination is not displayed correctly on mobile when totalPages > 5.

Tradeshift UI version affected

v9.3.13

Expected Behavior

Pagination should be displayed correctly on mobile when totalPages > 5.

Actual Behavior

Pagination is not displayed correctly on mobile when totalPages > 5.

Steps to reproduce

Use pagination for totalPages > 5.

Screenshots (optional)

pagination_mobile

wiredearp commented 6 years ago

@MirelaPaun Hm 😕 The Table is supposed to reduce the number of page-buttons from 5 to 3 in the mobile breakpoint; and this also appears to work alright on the Docs website (for example in http://ui.tradeshift.com/#components/table/demo.html), so I am not sure exactly what went wrong. I assume that this footer is part of the Table (and not generated via the dedicated Footer API)? What are those strange dots near the top of the footer (between the footer and the Table body) ❓

MirelaPaun commented 6 years ago

I used Footer component and Pager from Footer here. You can reproduce this issue here http://ui.tradeshift.com/#components/footer/pager.html.

Those strange dots is the next row from the table. Sorry for this stupid screenshot.

wiredearp commented 6 years ago

Right. That is a bug, then. But anyways, the Table also comes with a built-in footer plus pager and this one does not have the problem. So unless you are using the Footer for other purposes, perhaps you can work around the bug by using the Table footer instead of the general purpose Footer: http://ui.tradeshift.com/#components/table/paging.html

MirelaPaun commented 6 years ago

Thanks :+1:

tynandebold commented 6 years ago

Fixed in PR #526.