Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

Invisible ts.ui.Notification #590

Open jmredfern opened 6 years ago

jmredfern commented 6 years ago

Bug report

We're displaying a Notification when the server connection drops, and auto accepting the Notification after some time to retry the connection. The issue happens when closing the Mac laptop, waiting some moments and opening it again. An invisible Notification dialog is present on the page with a the shaded background cover visible.

Tradeshift UI version affected

v10.0.19

Expected Behavior

Notification appears

Actual Behavior

Notification is invisible

Steps to reproduce

Notes

We used a hack which seems to avoid this issue, which is opening the Notification within a window.requestAnimation callback.

https://github.com/Tradeshift/tradeshift-go/blob/go/src/client/main/ReconnectHelper.js#L13-L22

Screenshots

image

lloydhumphreys commented 5 years ago

Still relevant in V12.