Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
In Chrome Developer Tools, choose Timeline and check Memory. Then hit record, open a SELECT (with associated Aside) some 25 times and stop recording. We'll notice a steady increase in event listeners and that's the bug.
All elements added by the Client-Runtime are accounted for during cleanup and, more importantly, all event listeners setup via the Client-Runtime (see ts.ui.EventPlugin) are accounted for when the components get cleaned up, so PolymerGestures could - in theory - be the source of the leak. In that case, we can tie the bug up to https://github.com/Tradeshift/Client-Runtime/issues/188.
DocGroth
commented
5 years ago
In Chrome Developer Tools, choose
Timelineand checkMemory. Then hit record, open a SELECT (with associated Aside) some 25 times and stop recording. We'll notice a steady increase in event listeners and that's the bug.All elements added by the Client-Runtime are accounted for during cleanup and, more importantly, all event listeners setup via the Client-Runtime (see
ts.ui.EventPlugin) are accounted for when the components get cleaned up, so PolymerGestures could - in theory - be the source of the leak. In that case, we can tie the bug up to https://github.com/Tradeshift/Client-Runtime/issues/188.https://github.com/Tradeshift/Client-Runtime/issues/220