Tradeshift / tradeshift-ui

The Tradeshift UI Library & Framework
https://ui.tradeshift.com
Other
33 stars 45 forks source link

[Spinner] Spinner is not covering footer nor header #778

Closed Loredana-Noata closed 5 years ago

Loredana-Noata commented 5 years ago

Describe the bug In UI12, the spinner when is not active create an extra space in the bottom of the page. When is active, is visible in the bottom - is covering only half of the layout. When adding new property in our css (position: absolute) is not covering the footer nor header.

To reproduce See attached images.

Expected behavior When active, spinner should cover the whole page

Framework usage React 16.8.3

Desktop (please complete the following information):

Smartphone (please complete the following information): -not tested yet

Additional context

spinner_ spinner_ui11 spinnerUI12
zdlm commented 5 years ago

We changed the layout in V12. You can use new method to make a full page spinner

ts.ui.get('.ts-app', function(app) {
    app.blocking('Chrunching data');
    setTimeout(function() {
        app.done();
    }, 1500);
});

The link is here http://ui.tradeshift.com/v12/#components/spinners/