Tradeshift / tradeshift-ui

Tradeshift UI is a framework-agnostic JavaScript library to help Tradeshift App developers to create cohesive user experiences and to provide reusable UI components.
https://ui.tradeshift.com
Other
33 stars 44 forks source link

[Table] Support images in Table #87

Closed n-srg closed 7 years ago

n-srg commented 7 years ago

Currently we can insert only ts-icons in table cells using the code below

function geticon(type, color = 'black') {
    return {
        item: 'Icon',
        type: type,
        color: color
    }
}

But in fact we need to implement handling external images (e.g. .PNG and other image types)

tcomboeanu commented 7 years ago

It would be nice if we can also include a UserImage in a table cell. :muscle:

wiredearp commented 7 years ago

@tcomboeanu and @n-srg and @vvvts Better late than never, we now have minimum viable support for images and UserImages on the Table over on http://ui.tradeshift.com/#components/table/extras.html (it's in the 7.0.0-alpha.26 release which is not yet merged to master in V4). We figure that we will need to support this with some additional features, not least a fixed width for the column that contains the images (we currently only have a minwidth for the columns) and perhaps we also need to support a UserCard which, in addition to the image, also shows the name and email address of the user (?). In any case, feel free to add additional feature requests here so we can keep the issue alive :beer:

n-srg commented 7 years ago

@wiredearp sound like magic. much thanks! will use it when it will come to v4. :beers:

any thoughts about release date for v4?

wiredearp commented 7 years ago

@n-srg The next release comes out with an extensive revision of the Forms UI and since it must be released into all the apps at once, we'll have to first allow everyone (including you) to test the next release in their favorite app and then implement the fixes that needs to be done. So I can't really promise an exact date :cry: but you can of course start testing your app today by setting the Runtime to 7.0.0-alpha.26 in config.json in the Apps-Server (and then restart the server) just to see if anything explodes.

vvvts commented 7 years ago

Looks great here http://ui.tradeshift.com/#components/table/extras.html! :beers: Will try in apps...