Tradeshop / TradeShop

Unique, new, powerful Minecraft TradeShop plugin!
https://tradeshop.github.io
Apache License 2.0
25 stars 11 forks source link

Permission to USE TradeShop #117

Closed LKits closed 2 years ago

LKits commented 2 years ago

Is your feature request related to a problem?

No

Describe the solution you'd like.

Please add a permission to USE TradeShop. So I can give permission to specific group that can use TradeShop.

For example: tradeshop.use

Describe alternatives you've considered.

At the moment aren't any.

Agreements

Other

No response

SparklingComet commented 2 years ago

Hi there, thanks for the suggestion. As a counter-suggestion, how about adding a permission (such as tradeshop.noTrade) to stop users from buying from shops instead? I believe this would also be a solution to the situation you pointed out on Discord.

LKits commented 2 years ago

tradeshop.noTrade doesn't seem to be doing anything. Permission group that I added "tradeshop.noTrade allow" to can still buy from the shop.

SparklingComet commented 2 years ago

There seems to be a misunderstanding. That permission does not yet exist, we're suggesting to add it.

LKits commented 2 years ago

That would certainly solve my situation. And I understand why you don't want to add "whitelist" permission, then your plugin wouldn't work "out-of-box". "Blacklist" permission would work great!

SparklingComet commented 2 years ago

That would certainly solve my situation. And I understand why you don't want to add "whitelist" permission, then your plugin wouldn't work "out-of-box".

Yes that is part of the rationale. Alright then, we'll add this to the todo list for the next release.

KillerOfPie commented 2 years ago

@LKits Try out the newest dev release and let me know if it functions the way you need it to

The permission is tradeshop.prevent-trade

LKits commented 2 years ago

Works perfectly, thank you very much!