search

Tradeshop / TradeShop

Unique, new, powerful Minecraft TradeShop plugin!
https://tradeshop.github.io
Apache License 2.0
25 stars 11 forks source link

2.5.0 #118

Closed KillerOfPie closed 2 years ago

KillerOfPie commented 2 years ago

Pull Request Etiquette

There are several guidelines you should follow in order for your Pull Request to be merged. Replace [ ] with [x] to cross the checkbox.

It is sometimes better to include more changes in a single commit. If you find yourself having an overwhelming amount of commits, you can rebase your branch.

Changes

Replace this sentence with a description of che changes introduced by this PR.

KillerOfPie commented 2 years ago

Not sure I understand correctly, but it seems to me that if unlimited-admin is set to true, this means players with higher privileges can do what they want (which is what was requested).

However, I think we should add a step in between, namely that doing so still requires admin mode enabled for that specific player. That way, admins can both serve as staff members and play play the game as regular users without the two things interfering with one another.

This is already being done anywhere the unlimited check was added (Setting.UNLIMITED_ADMIN.getBoolean() && Permissions.isAdminEnabled(pSender))

SparklingComet commented 2 years ago

This is already being done anywhere the unlimited check was added (Setting.UNLIMITED_ADMIN.getBoolean() && Permissions.isAdminEnabled(pSender))

Alright, thanks for the clarification