Tradeshop / TradeShop

Unique, new, powerful Minecraft TradeShop plugin!
https://tradeshop.github.io
Apache License 2.0
25 stars 11 forks source link

Permission improvements #138

Closed KillerOfPie closed 11 months ago

KillerOfPie commented 2 years ago

Test Points:

SparklingComet commented 2 years ago
Name Enabled by default?
Help :heavy_check_mark:
Create :heavy_check_mark:
Create Infinite :x:
Create Bi :heavy_check_mark:
Admin :x:
Edit :heavy_check_mark:
Info :heavy_check_mark:
Manage Plugin :x:
Prevent Trade -> Trade :heavy_check_mark:
SparklingComet commented 2 years ago

we might not need the "internal level" anymore

SparklingComet commented 2 years ago

Also, I think the default status should not be made configurable

KillerOfPie commented 2 years ago
  • If Permissions properly work without a permissions plugin and with internal-permissions disabled then remove internal permissions.

If Permissions properly work without a permissions plugin and with internal-permissions disabled then remove internal permissions. yes.

Also, I think the default status should not be made configurable

Agreed.

Name Enabled by default? Help yes Create yes Create Infinite no Create Bi yes Admin no Edit yes Info yes Manage Plugin no Prevent Trade N/A: we would remove this one

Prevent Trade should be replaced with Trade which would be enabled by default, edited your table to reflect this since I will probably build off of that.

KillerOfPie commented 1 year ago

Completed in #127