1.20 Incompatible (editable signs)

FireController1847 commented 1 year ago

Expected behavior

Right clicking on a sign does not open the edit menu (the plugin should cancel the interaction).

Observed/Actual behavior

Right clicking on a sign makes it editable, and then the shop breaks following.

Steps/models to reproduce

1) Place a sign and make a TradeShop. 2) Set it up with a product and cost 3) Right click on the sign to trade 4) The sign is edited instead 5) The TradeShop breaks

Plugin list

N/A

TradeShop version and Minecraft version (CraftBukkit/Spigot/Paper/...)

> ts help
[16:28:28 INFO]:
TradeShop 2.6.0-STABLE by Lori00 & KillerOfPie

/tradeshop   Display help message
/ts help   Display help message
/ts setup   Display shop setup tutorial
/ts bugs   Report bugs to the developers
/ts reload   Reload configuration files

> version
[16:28:17 INFO]: Checking version, please wait...
[16:28:18 INFO]: This server is running Paper version git-Paper-45 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: b169678)
You are 11 version(s) behind
Download the new version at: https://papermc.io/downloads/paper
Previous version: git-Paper-549 (MC: 1.19.4)

Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.
[ ] My version of Minecraft and TradeShop are supported by the TradeShop Dev Team (when in doubt, first ask on the Discord).

Other

I searched far and wide for the invite to the Discord but the link given everywhere (https://discord.link/TradeShopPlugin) is broken (gives a 502 Bad Gateway), so I wasn't able to ask or search on there. Sorry if this is already a known issue. At least there's a formal GitHub issue for it now too, though.

KillerOfPie commented 1 year ago

This should be hixed in the latest dev version. The fix only works for Paper servers running 1.20.1 build # 51 or newer.

FireController1847 commented 1 year ago

@KillerOfPie Do you know of anywhere I could get access to a build of this dev version? I noticed the last officially released dev build (according to GitHub) was back in 2022. If I need to build it myself I can, but of course if one is available I'd prefer to snatch that one :heart:

gre3x commented 1 year ago

https://jenkins.killerofpie.com/job/tradeshop/

KillerOfPie commented 1 year ago

Should be all good in #156

Tradeshop / TradeShop