Open ChristopherPS96 opened 10 months ago
Hi there, thanks for your report. We are aware of this issue, but haven't fixed it yet (we are stretched thin at the moment). You can try to fix the newlines manually in the display-name
fields and see if that works. If not, let us know.
If you manage to identify the issue and fix it feel free to open a PR, that would be extremely appreciated.
Hey, I don't think I'll have the time to read myself into a new code base.
But I think I narrowed down the problem. As long as the item doesn't have a display name of any kind, the saving of the trades work. Doesn't matter if it's a banner, book or anything really.
And fixing the display-name
doesn't work really consistent, since it can delete the content after that.
We are aware the issue is related to the serialization of the item display name. We are currently stretched thin though, which is why it is taking time.
I believe the trade works if a banner with the base color is set as the product, and then the custom banners are added to the chest. Not suggesting this as a solution to the error of course.
Stack trace
Plugin list
Actions to reproduce (if known)
If I would guess, the plugin has a problem with the specific name, being not italic. But that is just a guess on my side.
TradeShop version and Minecraft version (CraftBukkit/Spigot/Paper/...)
This server is running Paper version git-Paper-196 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 773dd72) You are running the latest version Previous version: git-Paper-137 (MC: 1.20.1)
TradeShop 2.6.1-STABLE by Lori00 & KillerOfPie /tradeshop Display help message /ts help Display help message /ts setup Display shop setup tutorial /ts bugs Report bugs to the developers /ts metrics Displays the plugins counted metrics. /ts reload Reload configuration files
Agreements
Other
While I have searched the already open issues, it was claimed to be fixed here:
153
Since it seems to be not or the error just seems to be similar, I want to give more feedback here.
I have experience in programming and java programming, so if more information is needed, feel free to ask.