search

Tradeshop / TradeShop

Unique, new, powerful Minecraft TradeShop plugin!
https://tradeshop.github.io
Apache License 2.0
25 stars 11 forks source link

2.1.0 #61

Closed KillerOfPie closed 5 years ago

KillerOfPie commented 5 years ago

Ready To be checked

I may have built this on my 2.0.1 and had to push to 2.1.0 once done hopefully everything from 2.0.1 got through

Release Notes

https://github.com/SparklingComet/TradeShop/wiki/2.1.0-Release-notes

smashedbotatos commented 5 years ago

Changed to spigot-api 1.14, and built. Working well, but errors on shop breaking. Hoppers no longer take items from cshops, but they will ADD items to a shop.

After the shop chests are broken, the json is not being deleted. I think it is from this error on breaking the shop.

On breaking a shop this is the error. [22:29:41] [Server thread/ERROR]: Could not pass event BlockBreakEvent to TradeShop v2.1.0 org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:320) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:520) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:505) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.PlayerInteractManager.breakBlock(PlayerInteractManager.java:286) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.PlayerInteractManager.a(PlayerInteractManager.java:219) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1203) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.PacketPlayInBlockDig.a(SourceFile:40) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.PacketPlayInBlockDig.a(SourceFile:10) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:13) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:135) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:114) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.MinecraftServer.aW(MinecraftServer.java:895) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:888) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(SourceFile:123) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:872) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:805) [minecraft_server.jar:git-Spigot-093165d-cb3d14c] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_212] Caused by: java.lang.NullPointerException at org.shanerx.tradeshop.objects.ShopChest.resetName(ShopChest.java:137) ~[?:?] at org.shanerx.tradeshop.listeners.AdminEventListener.onBlockBreak(AdminEventListener.java:82) ~[?:?] at sun.reflect.GeneratedMethodAccessor213.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_212] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_212] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:316) ~[minecraft_server.jar:git-Spigot-093165d-cb3d14c] ... 19 more

KillerOfPie commented 5 years ago

Changed to spigot-api 1.14, and built. Working well, but errors on shop breaking. Hoppers no longer take items from cshops, but they will ADD items to a shop.

After the shop chests are broken, the json is not being deleted. I think it is from this error on breaking the shop.

On breaking a shop this is the error. clip

Literally just fixed all that :P I left the hopper input working as i figure that's not necessarily a problem that we need to manage, plus allows players to have a little extra storage for their shops.

And shop json isn't deleted when chest is broken, chest is just removed from the shop and the shop is closed(now) thanks for the input though would've been very useful if i hadn't happened to already be working on it.

KillerOfPie commented 5 years ago

Also @smashedbotatos I made a discord for the plugin help and such if you wanted to join it. https://discord.gg/qzdSUnw

KillerOfPie commented 5 years ago

@SparklingComet Im probably going to added one or two more small features but this is basically done if you could give it a look over

*Edit: I take that back, I am done with this update, I think i've added and fixed plenty

KillerOfPie commented 5 years ago

I've already added all the features that I want in this version, so its ready. In 2.2.0 we need to have the Add-On Support done so i can work on the add-on plugins for Economy and Custom Items.

SparklingComet commented 5 years ago

^^ fixed merge conflicts

KillerOfPie commented 5 years ago

Because it is works on both versions