Closed mmazzarolo closed 7 years ago
Don't you think the code is too short to create multiple files?, I didn't know that you could import html
I don't think so, especially if it is a library which might grow in the future (but it also is a matter of personal preference, of course :) )
The code linting and styiling though should be required for PRs in my opinion, so that you can avoid issues like #14 but whatever.
Just my 2 cents, I opened an issue instead of a PR because I'm aware that it's also a matter of taste!
I agree that this project is now at a stage where we should maybe start thinking about an agreed upon linting procedure. I hear prettier 💅 is all the rage these days 💪. Should we perhaps create a separate issue for it?
I can't praise Prettier higly enough, it simply rocks!
Hi there, thanks for the library.
I noticed that the code of the lib can be simplified/cleaned up a lot, if you're interested here is a solution similar to the one I adopted in my current project (I used Flowtype in my project, so I stripped it from this example).
Let me know if you're interested in a PR.