search

TradingPal / react-native-highcharts

📈 Add Highcharts charts to react-native app for IOS and Android
https://github.com/TradingPal/react-native-highcharts
256 stars 158 forks source link

Cancel user-select to prevent users to see the bubble on ios #44

Closed luisfmsouza closed 6 years ago

luisfmsouza commented 6 years ago

When users are navigating throw the chart, sometimes they hold a tap and slide it. This behavior shows a native Safari popup with Copy | Look Up | Share... options.

image

I opened this PR in order to prevent this behavior. Now, the popup will never appears.

Infinity0106 commented 6 years ago

do you know that is the copy information? is it usefull to copy the data or not? what do you think, I belive in some cases it is usefull but let me know what you think.

luisfmsouza commented 6 years ago

I don't think the copy is useful in this context.

Imagine this case: the user swipe left and right in order to see the tooltip value in different positions, but suddenly the Copy ... appears and a text is selected. This behavior mess up with the chart.

Also, I'm not sure if there's useful information to be copied from the chart. Even if you want to select and copy some text from the axis, it's going to be really hard and you are not able to manual select the tooltip content to copy.

So, finally, this Copy... is a browser behavior. As we are trying to simulate a native experience, I think it move us away from our target(native behavior).

What you think?

Infinity0106 commented 6 years ago

Oh I see your point know, in that case we don't need the copy...,

thanks for your PR