search

TradingPal / react-native-highcharts

📈 Add Highcharts charts to react-native app for IOS and Android
https://github.com/TradingPal/react-native-highcharts
256 stars 158 forks source link

Update readme adding chart's props documentation #66

Closed NachoJusticia closed 6 years ago

NachoJusticia commented 6 years ago

Hi! I love your library and the way you wraps Highcharts for react-native applications.

I think the lane {...this.props}added by @Infinity0106 is awesome. I was crazy trying to solve some rendering problems that causes that my charts renders with different sizes each time.

When I entered the code of this module and find scalesPageToFit and automaticallyAdjustContentInsets something came to my mind, and passing these two properties set to false to the ChartView solved my problem.

I think this is the same problem that are shown in these issues:

Therefore, I have added the corresponding documentation to the README file because I think that it is very useful to know this configuration. 👍

NachoJusticia commented 6 years ago

If you don't want to merge this PR I/you can close it