Traewelldroid / traewelldroid

Android app for @Traewelling public transport check-in service
https://traewelldroid.de
GNU Affero General Public License v3.0
72 stars 9 forks source link

[Auth] App crashes on Login with Firefox as only available browser #249

Closed echtnurich closed 1 month ago

echtnurich commented 1 year ago

Describe the bug As of right now, Firefox for Android is blocklisted due to issues with callback during auth. If there is no other Browser installed, the App will crash

To Reproduce Steps to reproduce the behavior:

  1. Install Firefox for Android
  2. Removed/Deactivate all other Browsers
  3. Try to authenticate with a Check-in provider

Expected behavior It Just works.

Proposed solutions:

  1. Do not Blocklist Browsers outright
  2. Prompt the User to Use blocklisted (greylisted?) Browsers, explaining there might be issues.

Smartphone:

jheubuch commented 1 year ago

I think this could be done by fixing the OAuth Callback URL to a custom scheme, not https.

Additionally the ActivityNotFoundException should be caught.

https://sentry.traewelldroid.de/organizations/traewelldroid/issues/162/events/8a7e3574303a411ab15ab4f32c3ec287/

jheubuch commented 1 year ago

Just need to re-open that open 🥴

echtnurich commented 1 year ago

Just to bump this, multiple people told me that they would use the App, if only they could log in without installing another browser.

It would really be nice to have a way to still use FF, forfeiting all rights to complain about FF-related bugs of course. ;)

jheubuch commented 1 year ago

Yeah, sure, that's why I reopened the issue 🥴

rugk commented 6 months ago

Oh uff, I know for other apps this workflow works/worked. Is there already a bug report at Mozilla for this? Or don't they do anything wrong and your app should not crash uhm…

jheubuch commented 1 month ago

I added an HTTP redirect rule to my webserver which redirects to my app custom theme when accessing via Browser. This results in automatically opening Träwelldroid after authenticating