Traewelldroid / traewelldroid

Android app for @Traewelling public transport check-in service
https://traewelldroid.de
GNU Affero General Public License v3.0
67 stars 8 forks source link

Travelyx checkin do not apply same visibility setting #347

Closed rugk closed 2 months ago

rugk commented 2 months ago

Describe the bug AFAIK when you checkin to both Traewelling and Travelyx, the "visbility/privacy settings", i.e. whether a checkin is public, follower-only, etc. is not applied to Travelyx.

To Reproduce

  1. Setup both checkin services.
  2. Select "follower-only" in checkin dialog.
  3. Checkin.

Only on Traewelling it is set to follower-only then…

Expected behavior For privacy/security/POLA reasons, it should keep the same visibility in all network services. Otherwise private information can of course be exposed.

Screenshots N/A

Smartphone (please complete the following information): Device: Fairphone 4 (FP4)
OS: Android 14, CalyxOS 5.5.2. source: F-Droid
version: v. 2.7.1
Build-ID: AP1A.240305.019.A1.24505020

Additional context N/A

jheubuch commented 2 months ago

According to the API docs, there is no possibility to send some visibility (at least i don't see it?).

https://travelynx.de/api

rugk commented 1 month ago

The big JSON at least lists it:

"visibility" : {
"desc": "private" / "unlisted" / "followers" / "travelynx" / "public",
"level": 10 / 30 / 60 / 80 / 100
}

But that may be readonly hmm?

So opened an issue for that: https://github.com/derf/travelynx/issues/135

(BTW, you may add/use a tag "blocked" for such issues, depending on outside factors.)