Traewelling / line-colors

This repository collects German public transport line colors.
https://traewelling.github.io/line-colors/
Creative Commons Zero v1.0 Universal
29 stars 41 forks source link

Update NRW colours for 2024 #65

Closed metrophil closed 8 months ago

metrophil commented 9 months ago

Please only merge this on or after 10 December 2023

bendix-dev commented 9 months ago

When you change the operator the line icons would disappear for old check ins. I think you should rather duplicate those line entries.

marhei commented 9 months ago

I don't think it's a good idea to leave outdated data in the csv. There are already conflicts between different regions with the same line names and operators, that would only increase this problem.

fzakfeld commented 6 months ago

I think it is a bad idea to remove styles from historical checkins. Perhaps you should add a "valid from/to" field?

There is no icon for Hamburg S11 etc anymore.

jheubuch commented 6 months ago

I think it is a bad idea to remove styles from historical checkins. Perhaps you should add a "valid from/to" field?

There is no icon for Hamburg S11 etc anymore.

As this is not a collection of line icons just for Träwelling check-ins (it should be a generally usable dataset), I don't think that it is useful to collect historical data.

Nevertheless please use Discussions or Issues for topics like that. A merged merge request is not the right place to discuss specification changes 😅