search

Traewelling / traewelling

Free check-in service to log your public transit journeys
https://traewelling.de
GNU Affero General Public License v3.0
224 stars 43 forks source link

:technologist: Replace user details by `LightUserResource` in `LeaderboardUserResource` #2635

Closed marhei closed 3 days ago

marhei commented 1 month ago

To provide the same basic informations across all user resources

marhei commented 1 month ago

Maybe some also needs to recreate the API docs, I don't know how this works…

marhei commented 1 week ago

@MrKrisKrisu As you wanted: LeaderboardUserResource returns now a LightUserResource

marhei commented 4 days ago

@HerrLevin May I be merged? 🥺👉👈

HerrLevin commented 4 days ago

@marhei I know where you're coming from. From a client pov I would prefer the original user pov. But I know our code and our database... This would most likely impact our performance (which we don't have :D) severely 🥴

I'm fine with the PR as it is currently, if you revert the two code occurences I've mentioned in my review. /cc @MrKrisKrisu

marhei commented 3 days ago

I removed all unwanted changes, thanks for the review!