search

Traewelling / traewelling

Free check-in service to log your public transit journeys
https://traewelling.de
GNU Affero General Public License v3.0
223 stars 43 forks source link

mastodon integration is forgotten instantly #2700

Open tastytea opened 1 week ago

tastytea commented 1 week ago

Describe the bug

i can add a mastodon API connection, it looks like it succeeded, the access token is visible on my instance.

but träwelling instantly forgets it exists and shows it as not connected. it worked up until recently, i think the last time i used it was 2-3 weeks ago?

i'm using sharkey 2024.3.3

Steps to reproduce

  1. go to https://traewelling.de/settings/security/login-providers
  2. connect to sharkey instance
  3. try to post a new status
  4. look at https://traewelling.de/settings/security/login-providers again to see that the integration is disconnected

Browser console logs

No response

Browser

firefox 127.0.1

MrKrisKrisu commented 1 week ago

We currently only support "real" mastodon connections. See https://github.com/Traewelling/traewelling/issues/2560

CutestNekoAqua commented 4 days ago

We currently only support "real" mastodon connections. See #2560

This seems to be a different issue and it seems to be resulting in your commit from 3 weeks ago. Having the same issue on akkoma. Seems to be a issue with Traewelling requesting things out of scope I think? I wrote the original Calckey Mastodon API and tested it against traewelling. Removing connections just because some instances return a 401 error that aren't official Mastodon instances doesn't seem like the right approach.

Additionally, all random instance errors while fetching an instance are being classified as "not a Mastodon instance," which gives the impression that all internal Traewelling errors on the API side are being labeled with an "official Mastodon only" policy.

There's a small difference between supporting Mastodon and supporting the Mastodon API. As a Mastodon-compatible software developer, I'd suggest focusing on supporting the API rather than just the official Mastodon instances. Otherwise, there is a risk of alienating a significant portion of users that would have loved the platform otherwise. That, I would not count as the spirit, FOSS software should life in.