search

Traewelling / traewelling

Free check-in service to log your public transit journeys
https://traewelling.de
GNU Affero General Public License v3.0
225 stars 45 forks source link

Potsdam is weird #794

Closed jeyemwey closed 2 years ago

jeyemwey commented 2 years ago

Describe the bug When checking into local transport in Potsdam, weird errors occur.

To Reproduce Steps to reproduce the behavior:

  1. Find a Station in Potsdam, e.g. Potsdam Plantagenstr. (IBNR: 736165)
  2. Find a tram or bus stop, e.g. STR 99
  3. Try to checkin later on that trip, e.g. at S Babelsberg/Wattstr.

Expected behavior Successful checkin with correct distance.

Additional context This happens with the main application, the admin interface, and in some cases with the Android app (however, @jheubuch said that the app does not encode slashes in URIs correctly). The issue was originally reported by @jeriox in the hotline.

jeriox commented 2 years ago

@jeyemwey I tried to reproduce the bug on a local instance, but everything worked flawlessly. I could also check in to the connection from yesterday that produced this bug: https://traewelling.de/status/312606 Do you have any ideas on how to narrow this down?

MrKrisKrisu commented 2 years ago

Did you test it before or after the commit from #789 two hours ago?

This PR changed the check-in method to a newer one and also contains an improvement for ring lines.

jeriox commented 2 years ago

My local repo was on 841cb7ca4e76a24ec79ae16a110130be249b3b23 while testing.

I just noticed that all checkins that I had trouble with in the last two days that I could now check in to are displayed with a distance of 0km. This applies to the checkin above as well as https://traewelling.de/status/312609 and https://traewelling.de/status/312610

MrKrisKrisu commented 2 years ago

That's hard to reproduce. I tried to check into your statuses, but the calculated distance is > 0.

image

MrKrisKrisu commented 2 years ago

For this trip the calculated distance is weird. I don't know this line, but based on the polyline displayed, I doubt that the ride is 12 km long.

image

MrKrisKrisu commented 2 years ago

STR 94 is a ring line. image

jeriox commented 2 years ago

Oh, I didn't know that this also counts as a ring line because these are two trips (forward to Schloss Charlottenhof and the return trip to Fontanestraße). Thanks for fixing!