TrafficPLANit / PLANit

see www.goPLANit.org
Other
0 stars 0 forks source link

Class InfrastructureLayer is not named correctly as there is no infrastructure in it #60

Closed MarkRaadsen closed 2 years ago

MarkRaadsen commented 3 years ago

Class InfrastructureLayer is not named correctly as there is no infrastructure in it. It should be named TransportLayer.

The TransportNetwork should then be renamed to avoid confusion. For now rename it to TransportModelNetwork as it combined virtual network with the "observable" physical/service networks. Not ideal but better than keeping original name.

This is eneded becasuer service networks are not infrastructure, but they are topological, and since topological networks derived from infrastructurenetworks, it is clear this naming is not correct at this point, the above changes solve this.

MarkRaadsen commented 2 years ago

do not use transport layer, but network layer instead, thatis more natural and planit is by defintion for transport so it is probably more appropriate, also given the package it is in