TrakHound / MTConnect.NET

Fully featured .NET library in C# to build MTConnect Agent, Adapter, and Client Applications. Pre-built Agents with Windows Installers. Support for Windows and Linux. Supports MTConnect Versions up to 2.3. Supports .NET Framework 4.6.1 up to .NET 8
http://www.TrakHound.com
MIT License
99 stars 39 forks source link

SHDR: Empty string handling #18

Closed MRIIOT closed 2 years ago

MRIIOT commented 2 years ago

Event with empty string is removed from SHDR stream, but leaves extra pipe. Replacing empty string with a blank space restores the data item in stream.

image

image

image

MRIIOT commented 2 years ago

This is probably related to #19 .

PatrickRitchie commented 2 years ago

I'm looking into this. The only way I found so far to get the first output you mentioned was to have a null ShdrDataItem.Key property (which you show in your screenshot has a value) so I'm not sure what would be causing that output. The ShdrDataItem should be able to handle an empty string.

I did add a commit afb85cfdb1dd545ae04d9093039bdc4430b22bb7 to prevent the extra pipe character from being output.

PatrickRitchie commented 2 years ago

Has anyone seen this issue in the latest versions?

MRIIOT commented 2 years ago

I have not.