TrakHound / MTConnect.NET

Fully featured .NET library in C# to build MTConnect Agent, Adapter, and Client Applications. Pre-built Agents with Windows Installers. Support for Windows and Linux. Supports MTConnect Versions up to 2.3. Supports .NET Framework 4.6.1 up to .NET 8
http://www.TrakHound.com
MIT License
96 stars 36 forks source link

XML Document formatted whitout newline #36

Closed EcTomBot closed 6 months ago

EcTomBot commented 1 year ago

Hello

Mazak's MT-Connet agent version 1.5.0.14 returns an XML document on a single line (see example below). currentExample2.zip

The ReadComponentStreamXml method does not read nodes correctly resulting in an exception. Commenting on reader.Skip (), as in the example below, the procedure seems to work, but I ask for your help to correct the problem. image

Thank you

PatrickRitchie commented 1 year ago

@EcTomBot It looks like you are correct that there is an issue with reading an XML document on a single line and it looks like your proposed changes will fix it. I'm working on an update that will implement these changes and should have an update ready this week.

Thanks, -Patrick

EcTomBot commented 1 year ago

Hi Patrick Have you definitively fixed the problem? When do I assume to distribute the update? Thank's

PatrickRitchie commented 1 year ago

@EcTomBot Sorry for the delay in response. Yes this seems to have fixed the issue and the changes are included in the latest commit 2653770c72f9cda1ed3f58f6ee60f13563d81ca9.

I will create a new Release with this included this weekend.

Thanks for the feedback and please let me know if you find any other issues.

Thanks, -Patrick

EcTomBot commented 1 year ago

Thank you very much

EcTomBot commented 1 year ago

Hi Parick When will the new release be released? Thanks and happy Sunday

EcTomBot commented 1 year ago

Hi Patrick Do you have good news for me? Thank you

PatrickRitchie commented 1 year ago

@EcTomBot Sorry for the delay. I just published a new Release v1.4.0 that includes this update.

Please let me know if you find any other issues and I appreciate the feedback.

Thanks -Patrick

EcTomBot commented 1 year ago

Thank you very much Tomaso

PatrickRitchie commented 1 year ago

@EcTomBot I just published the new v5.0.0 release with this change in it.

Thanks again for your feedback and let me know if you find anything else.

Thanks, -Patrick