TranceGeniK / bybit-tools

Desktop app to place scaled orders on bybit
GNU General Public License v3.0
106 stars 53 forks source link

Open on MAC #13

Closed gsibert closed 3 years ago

gsibert commented 4 years ago

Can't get the downloaded MAC app to open, could it be a Catalina issue?

TranceGeniK commented 4 years ago

https://github.com/electron/electron/issues/18660

gsibert commented 4 years ago

Notarization issue? https://medium.com/cacher-app/getting-your-electron-app-working-on-macos-catalina-10-15-63e53f397da2

TranceGeniK commented 4 years ago

Probably, problem is I don't have a mac myself to test it...

gsibert commented 4 years ago

Can you make a dmg target file instead of a zip? I can test that.

TranceGeniK commented 4 years ago

Dmg can only be built on macOS

https://github.com/electron-userland/electron-builder/issues/811

gsibert commented 4 years ago

Haven't compiled anything myself in years, and never on my MAC. However, managed to compile it on my own and it fires right up :)

TranceGeniK commented 4 years ago

great :) can you share the steps here for other people having the same issue please ?

gsibert commented 4 years ago

I'll put something together. The problem is I'm not sure what was relevant or unnecessary in my process :) Also, I had xcode and homebrew installed already which likely saved some steps versus starting from scratch.

SacreBleuXCVII commented 4 years ago

For anyone having the same problem, all I needed to do was type the build commands after cloning the repo and then if you go to the dist_electron/mac folder you'll find a compiled version that works.

TranceGeniK commented 3 years ago

macOS Install Instructions Download zip in an empty folder Unzip with keka (https://www.keka.io/en/) Ctrl-click on the unzipped app (https://support.apple.com/guide/mac-help/open-a-mac-app-from-an-unidentified-developer-mh40616/10.15/mac/10.15) Enjoy !