search

Trancever / reanimated-collapsible-helpers

reanimated-collapsible-helpers-git-master.trancever.vercel.app
MIT License
156 stars 26 forks source link

Reanimated 3 compatibility #54

Open efstathiosntonas opened 1 year ago

efstathiosntonas commented 1 year ago

Hi, is there any chance that you update this module to support reanimated 3? They totally dropped v1 support and this lib is still using some v1 methods e.g. Clock.

Thanks

efstathiosntonas commented 1 year ago

@Trancever reanimated 3.0.0 has been released, it would be great if this gets updated! Thanks

Randall71 commented 1 year ago

@efstathiosntonas in the past I did PR to update this package to reanimated 2 on #46 but I have no feedback. I think @Trancever is not too active in the community anymore.

chr4ss12 commented 7 months ago

@efstathiosntonas did you ever get around updating it to reanimated 3 library, if yes do you mind sharing it. I was interested seeing how your nested comments work

efstathiosntonas commented 7 months ago

hey @chr4ss12, just created this gist, I've modified this lib a bit though.

https://gist.github.com/efstathiosntonas/1a8c0ff35e57cd9e7d668e8d6304a0ca

edit: it's not a full example with comment lines, you can see the whole thing here that uses reanimated 2: https://github.com/efstathiosntonas/react-native-nested-comments-with-lines

chr4ss12 commented 7 months ago

@efstathiosntonas thanks, i appreciate it! I've gotten it working with the react-native-nested-comments-with-lines and with that gist, I also tried to use the newer files (RepliesLines), but I think there's one missing TopRowLeftBorderInnerView, if you wouldn't mind sharing that too

efstathiosntonas commented 7 months ago

@chr4ss12 I've updated the gist with the missing file