search

Traneptora / jxlatte

Java JPEG XL decoder
MIT License
44 stars 5 forks source link

Add Maven build support #28

Open meiMingle opened 10 months ago

Traneptora commented 10 months ago

I'm not sure where you're getting com.github.traneptora from - also you need to squash the commits.

meiMingle commented 10 months ago

I'm not sure where you're getting com.github.traneptora from

I just defined it based on your github account name, do you have a suggested GroupId?

also you need to squash the commits.

Yes, I will do this later

Traneptora commented 10 months ago

I just defined it based on your github account name, do you have a suggested GroupId?

As far as I understand it should be equal to the package name directly above the project. The project's base package is com.traneptora.jxlatte so as far as I understand, com.traneptora should be used. Although I may be mistaken.

Traneptora commented 10 months ago

Update: I forgot to rename the package when I changed my username, but it should be renamed now.

meiMingle commented 10 months ago

Now, I have finished modifying

Traneptora commented 10 months ago

pom.xml is missing a newline at the end of the file. Otherwise, I can test this today.

meiMingle commented 10 months ago

pom.xml is missing a newline at the end of the file. Otherwise, I can test this today.

Yes, I just fixed it

Traneptora commented 9 months ago

Make sure you squash the commits, then I can review.

BuZZ-dEE commented 1 week ago

Make sure you squash the commits, then I can review.

@Traneptora In GitLab you can squash it when you accept the merge request. I would assume the same is possible on GitHub. Is it not?

Traneptora commented 1 week ago

I only use Rebase And Merge because Squash and Merge makes silly commit messages. As such, I request a squash before I will review it.